Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add tagging commands #30

Merged
merged 8 commits into from
Nov 12, 2023
Merged

✨ Add tagging commands #30

merged 8 commits into from
Nov 12, 2023

Conversation

jossmoff
Copy link
Owner

Description

Provides the ability to tag and untag stories
Fixes #29

Type of change

Please tick options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jossmoff jossmoff linked an issue Nov 12, 2023 that may be closed by this pull request
2 tasks
@jossmoff jossmoff added this to the v1.0.0 milestone Nov 12, 2023
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #30 (9d9a56d) into main (51199b6) will increase coverage by 0.40%.
The diff coverage is 100.00%.

❗ Current head 9d9a56d differs from pull request most recent head 2a0e378. Consider uploading reports for the commit 2a0e378 to get more accurate results

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   93.57%   93.97%   +0.40%     
==========================================
  Files          11       11              
  Lines         420      448      +28     
==========================================
+ Hits          393      421      +28     
  Misses         27       27              
Files Coverage Δ
bookshelf/__init__.py 100.00% <100.00%> (ø)
bookshelf/models.py 73.25% <100.00%> (+2.74%) ⬆️
test/test_models.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jossmoff jossmoff merged commit fc19064 into main Nov 12, 2023
2 checks passed
@jossmoff jossmoff deleted the feature/add-tagging-commands branch November 12, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Add tag and untag commands
1 participant