Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Use Ruff Formatter #42

Merged
merged 3 commits into from
Jan 13, 2024
Merged

🎨 Use Ruff Formatter #42

merged 3 commits into from
Jan 13, 2024

Conversation

jossmoff
Copy link
Owner

Description

One formatter to rule them all!
Fixes # (issue)

Type of change

Please tick options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (5323210) 93.97% compared to head (62e046f) 93.97%.

Files Patch % Lines
bookshelf/models.py 68.42% 6 Missing ⚠️
bookshelf/storage.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files          11       11           
  Lines         448      448           
=======================================
  Hits          421      421           
  Misses         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jossmoff jossmoff merged commit 60ec2d2 into main Jan 13, 2024
5 of 6 checks passed
@jossmoff jossmoff deleted the feature/use-ruff branch January 13, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant