Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @ISBN10, @ISBN13 and @ISBN validators #12

Open
1 of 2 tasks
jossmoff opened this issue Jul 1, 2023 · 0 comments
Open
1 of 2 tasks

Add @ISBN10, @ISBN13 and @ISBN validators #12

jossmoff opened this issue Jul 1, 2023 · 0 comments
Labels
✨ enhancement New feature or request 👶 good first issue Good for newcomers 🧵string Relates to string based bean validation
Milestone
Version 1.0.0

Comments

@jossmoff
Copy link
Owner

jossmoff commented Jul 1, 2023 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Description

It would be useful for an @ISBN validator as we have no existing solution for this.

Solution

There is an ISBNValidator from apache commons. The documentation is here. We can use this to implement the isValid method. It has both an ISBN-10, ISBN-13 and a general ISBN validator that can be used for each annotation.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@jossmoff jossmoff assigned jossmoff and unassigned jossmoff Jul 1, 2023
@jossmoff jossmoff added ✨ enhancement New feature or request 👶 good first issue Good for newcomers labels Jul 1, 2023
@jossmoff jossmoff added this to the Version 1.0.0 milestone Jul 1, 2023
@jossmoff jossmoff added the 🧵string Relates to string based bean validation label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement New feature or request 👶 good first issue Good for newcomers 🧵string Relates to string based bean validation
Projects
None yet
Milestone
Version 1.0.0
Development

No branches or pull requests
1 participant
@jossmoff