Skip to content
This repository has been archived by the owner on Dec 31, 2019. It is now read-only.

Reviews lost when rebasing from master #9

Open
bahamat opened this issue Nov 29, 2018 · 0 comments
Open

Reviews lost when rebasing from master #9

bahamat opened this issue Nov 29, 2018 · 0 comments

Comments

@bahamat
Copy link

bahamat commented Nov 29, 2018

How to reproduce

  1. make change

  2. submit cr

  3. someone reviews

  4. someone approves

  5. Somewhere along the way, another change has already been merged upstream and now cannot fast-forward

  6. Run...

     git checkout master
     git pull
     git checkout $oldbranch
     git rebase master
     grr
    

Note, that grr was not run between IA and rebasing. This causes gerrit to consider this a "non-trivial" change, and wipes out the reviews/aproval.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant