Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ascii matching by default unintentionally? #5

Open
tysonkerridge opened this issue Oct 27, 2022 · 0 comments
Open

Ascii matching by default unintentionally? #5

tysonkerridge opened this issue Oct 27, 2022 · 0 comments

Comments

@tysonkerridge
Copy link

Hi, I was just wondering if there was a reason the default value for matching ascii is true in the Android tool kit yet false in the others? Not a huge issue as it can be changed, but I ran into an issue due to this and figured maybe it was unintended.

private boolean ascii = true; // convert ascii smileys? =)

https://github.com/joypixels/emoji-toolkit-ios/blob/dea870df5ca532d8ae8af97762070721205946d0/JoyPixels/JoyPixels/Client.swift#L13

https://github.com/joypixels/emoji-toolkit/blob/386935f8b715f76dd0bcdbc3bee54551a0023064/lib/php/src/Client.php#L11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant