Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 compatibility #68

Open
chrisdeeming opened this issue Nov 18, 2024 · 0 comments
Open

Add PHP 8.4 compatibility #68

chrisdeeming opened this issue Nov 18, 2024 · 0 comments

Comments

@chrisdeeming
Copy link

chrisdeeming commented Nov 18, 2024

Deprecated
: JoyPixels\Client::__construct(): Implicitly marking parameter $ruleset as nullable is deprecated, the explicit nullable type must be used instead in
/Users/chrisdeeming/Herd/24x/src/vendor/joypixels/emoji-toolkit/lib/php/src/Client.php
on line
29

I'll report back any other issues I find here (if any) but this one is a simple change at least:

public function __construct(RulesetInterface $ruleset = null)

Becomes:

public function __construct(RulesetInterface? $ruleset)

This will require the library to be updated to support at least PHP 7.1.

Still supporting PHP 5.3 in 2024 is, frankly, unnecessary!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant