Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[validation-gen] Improve tag parsing utilities #72

Open
jpbetz opened this issue Dec 13, 2024 · 1 comment
Open

[validation-gen] Improve tag parsing utilities #72

jpbetz opened this issue Dec 13, 2024 · 1 comment
Assignees

Comments

@jpbetz
Copy link
Owner

jpbetz commented Dec 13, 2024

#71 reminded that we haven't put all that much rigor into defining how we want tags to be structured. We're got a variety of adhoc parsing strategies that "get the job done" for the cases we've defined so far.

I think it's time we start to consolidate the parsing into a utility. I don't have strong options of how the utility should be structured or what "grammar rules" we should establish, but at the very least, it should be trivial to extract values of different types without having to write parsing code redundantly for each validation plugin.

@jpbetz
Copy link
Owner Author

jpbetz commented Dec 13, 2024

@yongruilin Any interest in taking a pass at this?

@yongruilin yongruilin self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants