Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from statik to go1.16 embed #13

Open
drmikecrowe opened this issue Jan 24, 2021 · 2 comments · May be fixed by #14
Open

Switch from statik to go1.16 embed #13

drmikecrowe opened this issue Jan 24, 2021 · 2 comments · May be fixed by #14

Comments

@drmikecrowe
Copy link
Contributor

I had a couple of issues hosting:

  • I was able to deploy my own version and update the .go files w/o an issue
  • When I tried to update the install script, I could not determine how to update scripts/install.sh and include.
  • I installed and was able run statik -dest=.. -f -p=scripts -src=../scripts -include=*.sh manually
  • Could not determine how to deploy to my heroku instance. Once I updated scripts/statik.go, I started getting 500 errors in heroku.
@drmikecrowe drmikecrowe linked a pull request Jan 24, 2021 that will close this issue
@jpillora
Copy link
Owner

Agreed, this can now be made much simpler with https://golang.org/pkg/embed/ newly released in go 1.16

Will update this issue, once we switch, then its just a go build and you're done

@jpillora jpillora changed the title Documentation: Provide instructions on how to develop/update install scripts Switch from statik to go1.16 embed Feb 18, 2021
@jpillora
Copy link
Owner

Sorry, I'm also assuming we won't need the extra documentation if it works with a go build - but maybe it still needs docs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants