From 29c9b74dc85396c9868352dffa42bfd225cef299 Mon Sep 17 00:00:00 2001 From: F745860 Date: Mon, 7 Oct 2024 06:46:42 +0530 Subject: [PATCH] review comments addressed --- packages/core/src/avatar/Avatar.tsx | 8 +++++--- packages/core/src/navigation-item/NavigationItem.tsx | 1 - 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/core/src/avatar/Avatar.tsx b/packages/core/src/avatar/Avatar.tsx index 236ef44e935..5da06a0c0a6 100644 --- a/packages/core/src/avatar/Avatar.tsx +++ b/packages/core/src/avatar/Avatar.tsx @@ -53,7 +53,7 @@ export const Avatar = forwardRef(function Avatar( src, size = DEFAULT_AVATAR_SIZE, style: styleProp, - fallbackIcon, + fallbackIcon: fallbackIconProp, ...rest }, ref, @@ -61,7 +61,9 @@ export const Avatar = forwardRef(function Avatar( const targetWindow = useWindow(); const { UserIcon } = useIcon(); - const fallBackIcon = fallbackIcon || ; + const fallbackIcon = fallbackIconProp || ( + + ); useComponentCssInjection({ testId: "salt-avatar", @@ -105,7 +107,7 @@ export const Avatar = forwardRef(function Avatar( {...initialsProps} {...rest} > - {children || avatarInitials || fallBackIcon} + {children || avatarInitials || fallbackIcon} ); }); diff --git a/packages/core/src/navigation-item/NavigationItem.tsx b/packages/core/src/navigation-item/NavigationItem.tsx index 3c9734ca0f9..f4996d11a9a 100644 --- a/packages/core/src/navigation-item/NavigationItem.tsx +++ b/packages/core/src/navigation-item/NavigationItem.tsx @@ -5,7 +5,6 @@ import { type MouseEventHandler, forwardRef, } from "react"; -import { useIcon } from "../semantic-icon-provider"; import { makePrefixer } from "../utils"; import { ExpansionIcon } from "./ExpansionIcon";