-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Salt AG-Grid theme supports v29+ ag grid #2103
Comments
You beat me to creating this, we've already discussed the next set of actions, and moving to the new CSS approach is part of it |
Updated release date, as work has not started. |
update target date to match subtask |
25 Oct - Chromatic snapshot to be design reviewed with @bhoppers2008 |
Moved the target date to 31st Oct to accommodate feedback from consumers |
Hard-coded colours need to be removed and mapped to Salt colours. |
3 Nov - PR ready for review, moving to feedback stage |
6 Nov - PR reviews and waiting for more to be able to merge. @joshwooding |
Almost ready, creating tests for UITK theme. Consumers not able to test the theme yet as they haven't begun their upgrade. PR still needs a review |
13 Nov - PR review requested this morning, Chromaticc tests added for uItk theme |
17 Nov - Fixing UITK theme to match on Chromatic / Cypress. |
20 Nov - wip, more test to be fixed. ETA tmr |
22 Nov - dev done. verifying test passing, review for dev & design review (both Salt and UITK theme). |
24 Nov - snapshot tests pass. Range selection bug raised. Can't merge to main, bug fixes needed for v1. |
27 Nov - doc changes on ag grid next branch. |
1 Dec - trying at snapshot (help from @lukeac123), at feedback stage. Keep in next branch. |
4 Dec - trying snapshot by @lukeac123. More thorough test needed. |
6 Dec - more tests to be added for range selection. discuss how to manage 2 ag grid theme version. |
8 Dec - Need additional icon (drag and drop row, GH issue? @pseys did it). Version management to be discussed. |
11 Dec - icons created, needs to be added to the icon font (how? to be confirmed). Version management to be discussed. |
18 Dec - Icons have been merged, and the data grid theme has been updated with the new icons. |
Closed by #3195 |
Currently ag grid is using Legacy SASS method to generate CSS, and need to move to new way.
Also new versions of ag grid introduced proper CSS like below
These will override Salt colors applied, so will need to follow new way of overriding colors.
StackBlitz Demo of ag grid v30 CSS variable breaking styling.
Tasks
The text was updated successfully, but these errors were encountered: