Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Button component to use new styles #3630

Closed
9 tasks done
pseys opened this issue Jun 24, 2024 · 13 comments
Closed
9 tasks done

Update Button component to use new styles #3630

pseys opened this issue Jun 24, 2024 · 13 comments
Assignees
Labels
Figma Related to Figma

Comments

@pseys
Copy link
Contributor

pseys commented Jun 24, 2024

New variables have been added to the Salt (next) styles library to accommodate Bordered Button.

  • The button component needs to be updated to use the new variables.
  • appearance and color props needs to be added to Button
  • appearance: solid | outline | transparent color: neutral | accent need to be added to Button

Figma implementation of #3325

Tasks

Preview Give feedback
  1. Figma role: design 🎨
    pseys
  2. Figma role: design 🎨
    pseys
@pseys pseys self-assigned this Jun 24, 2024
@pseys pseys converted this from a draft issue Jun 24, 2024
@pseys pseys added role: design 🎨 Figma Related to Figma labels Jun 24, 2024
@pseys
Copy link
Contributor Author

pseys commented Jun 24, 2024

For the updated Button component I think the least disruptive solution is to do the following:

  • Change cta button to accent button
    -- Add appearance as a prop with 3 options solid (as default), outline and transparent
  • Change primary button to neutral button
    -- Add appearance as a prop with 3 options solid (as default), outline and transparent

TBC

  • Change all instances of secondary button across the component library to use neutral button set to transparent
  • Remove secondary button

@mark-tate
Copy link
Contributor

Goal: S(3)
Figma published, tokens ready by 25/06/24
Dev work to start 26/06/24

@pseys
Copy link
Contributor Author

pseys commented Jun 26, 2024

The button component is complete and ready to publish, however, I need to check through all of the components it is dependent on and change any references to cta|primary|secondary

@pseys

This comment has been minimized.

@joshwooding
Copy link
Contributor

Blocked by #3325

@pseys
Copy link
Contributor Author

pseys commented Jul 18, 2024

The theme spec for #3325 is complete and has been handed over to development. I'm now able to start mapping the new tokens to the legacy and next style libraries so the Button components can be updated.

@pseys
Copy link
Contributor Author

pseys commented Jul 22, 2024

In the process of updating the Theme Characteristics file. Palette tokens have been updated.

@pseys
Copy link
Contributor Author

pseys commented Jul 22, 2024

Theme Characteristics file updated.

@pseys
Copy link
Contributor Author

pseys commented Jul 22, 2024

Salt (Next) Style Library updated in branch. Branch has been merged. Update has been published.

@mark-tate
Copy link
Contributor

mark-tate commented Jul 22, 2024

Goal: more examples added to Storybook
Close out by EOS

@pseys
Copy link
Contributor Author

pseys commented Jul 22, 2024

Salt (next) Component and Pattern Library updated. Branch has been merged but not published.

@pseys pseys moved this from Planned to Green in Salt - Components, Patterns and Theming Jul 24, 2024
@pseys
Copy link
Contributor Author

pseys commented Jul 25, 2024

Light and dark mode library changes in progress. Branches match the title of this issue.

@mark-tate
Copy link
Contributor

@navkaur76 are you able to review this for @pseys ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Figma Related to Figma
Projects
Development

No branches or pull requests

3 participants