Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma library cover design #4462

Closed
pseys opened this issue Nov 28, 2024 · 8 comments
Closed

Figma library cover design #4462

pseys opened this issue Nov 28, 2024 · 8 comments

Comments

@pseys
Copy link
Contributor

pseys commented Nov 28, 2024

To support #4461 a new cover design for Figma files needs to be created to create consistency across Salt files and aid discoverability by consumers when searching for resources.

@pseys
Copy link
Contributor Author

pseys commented Dec 2, 2024

  • Initial designs proposed.
  • @bhoppers2008 requested that the designs align more closely to JPM brand
  • Time scheduled with @honey-chang to discuss alternate background graphics

@pseys
Copy link
Contributor Author

pseys commented Dec 4, 2024

Design refined. Darrin has taken on design direction. Awaiting final agreement. Once Darrin/Ben are happy I'll centralise the design and add to our libraries.

@origami-z
Copy link
Contributor

need to make sure new thumbnail follows new dimension ratio

@pseys
Copy link
Contributor Author

pseys commented Dec 4, 2024

need to make sure new thumbnail follows new dimension ratio

Thanks Zhihao. We're following the 16:9 ratio. However, we're no longer following 1920 x 1080 size as Darrin has redesigned the cover to fit with our MD assets.

@mark-tate
Copy link
Contributor

closed by EOS mocha

@mark-tate
Copy link
Contributor

Red Eye Goal: complete by end of wk1

@yunjungyeh yunjungyeh self-assigned this Dec 10, 2024
@mark-tate
Copy link
Contributor

@dplsek says YES, update file and then close

@dplsek
Copy link

dplsek commented Dec 16, 2024

Per @pseys we'll use status tokens to style tags as overrides until tags support status and sentiment for these cover templates.

@dplsek dplsek closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants