From 0a2b17383700633cb601804521a2d391d3726b5b Mon Sep 17 00:00:00 2001 From: Liam Smith Date: Tue, 29 Oct 2024 21:07:44 +0000 Subject: [PATCH 1/5] Fix icon alignment --- packages/core/src/toast/Toast.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/toast/Toast.css b/packages/core/src/toast/Toast.css index d0b2f793bc2..573ec35a9d0 100644 --- a/packages/core/src/toast/Toast.css +++ b/packages/core/src/toast/Toast.css @@ -30,7 +30,7 @@ /* Styles applied to icon */ .saltToast-iconContainer > .saltIcon { - margin: calc(var(--salt-spacing-75) + 2px) 0 var(--salt-spacing-75) 0; + margin: calc(var(--salt-spacing-75) + min(var(--salt-spacing-25), 2px)) 0 var(--salt-spacing-75) 0; color: var(--toast-iconColor); } From 71c8273c89231b68807b726399cce4512c9c3fff Mon Sep 17 00:00:00 2001 From: Liam Smith Date: Tue, 29 Oct 2024 22:08:55 +0000 Subject: [PATCH 2/5] Update changeset --- .changeset/wet-swans-wave.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/wet-swans-wave.md diff --git a/.changeset/wet-swans-wave.md b/.changeset/wet-swans-wave.md new file mode 100644 index 00000000000..67475120e31 --- /dev/null +++ b/.changeset/wet-swans-wave.md @@ -0,0 +1,5 @@ +--- +"@salt-ds/core": patch +--- + +Fixed HD Toast icon alignment From 295f9cdb8624b14c406afa7b417c53906de02d9d Mon Sep 17 00:00:00 2001 From: Josh Wooding <12938082+joshwooding@users.noreply.github.com> Date: Tue, 21 Jan 2025 11:37:58 +0000 Subject: [PATCH 3/5] Align to Figma --- packages/core/src/toast/Toast.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/toast/Toast.css b/packages/core/src/toast/Toast.css index 573ec35a9d0..126cc2fb4f7 100644 --- a/packages/core/src/toast/Toast.css +++ b/packages/core/src/toast/Toast.css @@ -30,7 +30,7 @@ /* Styles applied to icon */ .saltToast-iconContainer > .saltIcon { - margin: calc(var(--salt-spacing-75) + min(var(--salt-spacing-25), 2px)) 0 var(--salt-spacing-75) 0; + margin-top: var(--salt-spacing-100); color: var(--toast-iconColor); } From e4ff503eb787d467bde02751a3dfc01dd328c0b1 Mon Sep 17 00:00:00 2001 From: Josh Wooding <12938082+joshwooding@users.noreply.github.com> Date: Tue, 21 Jan 2025 11:38:57 +0000 Subject: [PATCH 4/5] Update .changeset/wet-swans-wave.md --- .changeset/wet-swans-wave.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/wet-swans-wave.md b/.changeset/wet-swans-wave.md index 67475120e31..e63d5e270db 100644 --- a/.changeset/wet-swans-wave.md +++ b/.changeset/wet-swans-wave.md @@ -2,4 +2,4 @@ "@salt-ds/core": patch --- -Fixed HD Toast icon alignment +Fixed Toast icon alignment not matching Figma. From 2392f3539829d99f93052686074de318e3b5788c Mon Sep 17 00:00:00 2001 From: Josh Wooding <12938082+joshwooding@users.noreply.github.com> Date: Tue, 21 Jan 2025 13:29:24 +0000 Subject: [PATCH 5/5] Update --- .changeset/wet-swans-wave.md | 2 +- packages/core/src/toast/Toast.css | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.changeset/wet-swans-wave.md b/.changeset/wet-swans-wave.md index e63d5e270db..855e5e03ce0 100644 --- a/.changeset/wet-swans-wave.md +++ b/.changeset/wet-swans-wave.md @@ -2,4 +2,4 @@ "@salt-ds/core": patch --- -Fixed Toast icon alignment not matching Figma. +Fixed Toast icon alignment. diff --git a/packages/core/src/toast/Toast.css b/packages/core/src/toast/Toast.css index 126cc2fb4f7..8d8670e4787 100644 --- a/packages/core/src/toast/Toast.css +++ b/packages/core/src/toast/Toast.css @@ -30,7 +30,7 @@ /* Styles applied to icon */ .saltToast-iconContainer > .saltIcon { - margin-top: var(--salt-spacing-100); + margin-top: calc(var(--salt-spacing-75) + calc((var(--salt-text-lineHeight) - max(var(--salt-size-icon), 12px)) / 2)); color: var(--toast-iconColor); }