Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import('aa.js') not supported #2075

Open
jogibear9988 opened this issue Apr 12, 2021 · 8 comments
Open

import('aa.js') not supported #2075

jogibear9988 opened this issue Apr 12, 2021 · 8 comments

Comments

@jogibear9988
Copy link

No description provided.

@jogibear9988
Copy link
Author

I've done a fix for this in esprima.net
sebastienros/esprima-dotnet@272dd32

@jogibear9988
Copy link
Author

fix : #2076

@ariya
Copy link
Contributor

ariya commented Apr 12, 2021

Hi @jogibear9988, thanks for the report and the fix! For our future reference, this likely needs a reference to the specification, as well as some tests.

@jogibear9988
Copy link
Author

jogibear9988 commented Apr 13, 2021

there are already tests for "import(xxx)"

@jogibear9988
Copy link
Author

@jogibear9988
Copy link
Author

@jogibear9988
Copy link
Author

jogibear9988 commented Apr 13, 2021

my fix has one problem:

import('a','b') is no error (but it should be). but I don't know how this should be fixed atm. I'm not deep enough into esprima

@jogibear9988
Copy link
Author

the import('a', 'b') is now also fixed that it would fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants