Skip to content

Commit

Permalink
Merge pull request #236 from maplight/rails-8-support
Browse files Browse the repository at this point in the history
Add support for Rails 8.0
  • Loading branch information
jrochkind authored Nov 9, 2024
2 parents 9e5ca96 + d2d0b34 commit c616d4a
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ jobs:
- gemfile: rails_7_2
ruby: 3.3

- gemfile: rails_8_0
ruby: 3.3

name: ${{ matrix.gemfile }}, ruby ${{ matrix.ruby }}

steps:
Expand Down
7 changes: 7 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ appraise "rails-7-2" do
gem "pg", "~> 1.0"
end

appraise "rails-8-0" do
gem 'combustion', "~> 1.0"

gem "rails", "~> 8.0.0"
gem "pg", "~> 1.0"
end


appraise "rails-edge" do
# need combustion edge to work with rails edge, will no longer
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

*
* Allow Rails 8.0 in gemspec (no code changes required to support) https://github.com/jrochkind/attr_json/pull/236

*

Expand Down
2 changes: 1 addition & 1 deletion attr_json.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ attributes use as much of the existing ActiveRecord architecture as we can.}
# dependency included just as it is here, should never be released
# from an env tht has any of these variables set.
unless ENV['APPRAISAL_INITIALIZED'] || ENV["TRAVIS"] || ENV['CI']
spec.add_runtime_dependency "activerecord", ">= 6.0.0", "< 8"
spec.add_runtime_dependency "activerecord", ">= 6.0.0", "< 8.1"
end

spec.add_development_dependency "bundler"
Expand Down
18 changes: 18 additions & 0 deletions gemfiles/rails_8_0.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "combustion", "~> 1.0"
gem "rails", "~> 8.0.0"
gem "pg", "~> 1.0"
gem "rspec-rails", "~> 6.0"
gem "simple_form", ">= 4.0"
gem "cocoon", ">= 1.2"
gem "jquery-rails"
gem "coffee-rails"
gem "sprockets-rails"
gem "capybara", "~> 3.0"
gem "selenium-webdriver"
gem "byebug"

gemspec path: "../"

0 comments on commit c616d4a

Please sign in to comment.