Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reverb effect after master gain #42

Open
jsakas opened this issue Oct 12, 2017 · 3 comments
Open

Add reverb effect after master gain #42

jsakas opened this issue Oct 12, 2017 · 3 comments

Comments

@jsakas
Copy link
Owner

jsakas commented Oct 12, 2017

https://developer.mozilla.org/en-US/docs/Web/API/ConvolverNode

I think it would be awesome if we added a reverb effect after the master gain, this would really bring some of the sounds we are creating to life. It seems like convolution is a somewhat advanced topic, so I think for a basic implementation we could implement a 2-knob reverb effect that would be Dry/Wet and Decay

@SkylerWilliams
Copy link
Collaborator

🙌 global effects! maybe a compressor could be in the works too :P

@jsakas
Copy link
Owner Author

jsakas commented Oct 12, 2017

I would love it! See: #29

@jsakas
Copy link
Owner Author

jsakas commented Oct 12, 2017

Also should note that a reverb or compressor effect does not need any envelope or per-note modification, so it can be created as a new class in Subtractor.constructor() and attached really easily via the existing UI components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants