Skip to content

🐛 Bug: Badge markdown code is not correct and show invalid link #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AQIB-NAWAB opened this issue Apr 11, 2025 · 3 comments · May be fixed by #112
Open

🐛 Bug: Badge markdown code is not correct and show invalid link #111

AQIB-NAWAB opened this issue Apr 11, 2025 · 3 comments · May be fixed by #112
Assignees
@AQIB-NAWAB
Labels
🐛 Bug Something isn't working Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@AQIB-NAWAB
Copy link

Describe the bug

It's shows invalid link instead of the badge.

Steps To Reproduce

  1. Visit https://landscape.json-schema.org/
  2. open any company
  3. Click on the get badge

Image
4. Copy the code and try it on any live preview , here is one https://markdownlivepreview.com/

It not show badge and in case of asclii docs 90% it gives invalid link when user click on it

Expected Behavior

Screencast.from.2025-04-11.15-49-02.webm

Screenshots

Image

Device Information [optional]

- OS: Ubuntu 
- Browser: Firefox
- version: 337

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No
@AQIB-NAWAB AQIB-NAWAB added the 🐛 Bug Something isn't working label Apr 11, 2025
@AQIB-NAWAB
Copy link
Author

Hi @benjagm , please assign this issue to me. I have already implemented it locally.

Thanks

@benjagm benjagm added the Status: In Progress This issue is being worked on, and has someone assigned. label Apr 12, 2025
@benjagm
Copy link
Contributor

benjagm commented Apr 12, 2025

Go ahead @AQIB-NAWAB

@AQIB-NAWAB
Copy link
Author

Thanks , I'll drop PR soon.

@AQIB-NAWAB AQIB-NAWAB linked a pull request Apr 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AQIB-NAWAB AQIB-NAWAB

Labels
🐛 Bug Something isn't working Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve the markdown badge AQIB-NAWAB/landscape
2 participants
@benjagm @AQIB-NAWAB