Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the home page #92

Closed
JeelRajodiya opened this issue Oct 6, 2024 · 11 comments · Fixed by #93
Closed

Update the home page #92

JeelRajodiya opened this issue Oct 6, 2024 · 11 comments · Fixed by #93
Assignees
Labels
✨ Enhancement New feature or request hacktoberfest This issue is looking for contribution under hacktoberfest event Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@JeelRajodiya
Copy link
Member

JeelRajodiya commented Oct 6, 2024

Related #72

Currently the homepage has one button which is the direct link to the first step. We want to display all the links of the chapter in the home page.

Update the home page as per the given design

figma Link: https://www.figma.com/design/w8ow79jE7lJucJt2zZTbcz/Tour-of-JSON-Schema?node-id=2303-39&t=HRYIgoqFZ2J30ggg-1

Please try not to hardcode the links and chapter titles, You can get the title and links of the chapters using the contentManager class

New Design

image

@JeelRajodiya JeelRajodiya added Status: Available No one has claimed responsibility for resolving this issue. ✨ Enhancement New feature or request hacktoberfest This issue is looking for contribution under hacktoberfest event labels Oct 6, 2024
@gregsdennis
Copy link
Member

Shouldn't the styling match that of the main site?

@JeelRajodiya
Copy link
Member Author

JeelRajodiya commented Oct 6, 2024

Shouldn't the styling match that of the main site?

Yes it should, but I couldn't come up with a better design. We are only using the JSON Schema brand color to match with the theme.

@pavanydg
Copy link
Contributor

pavanydg commented Oct 6, 2024

@JeelRajodiya i will take this up. Please

@JeelRajodiya
Copy link
Member Author

@pavanydg please go ahead!

@JeelRajodiya JeelRajodiya added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Oct 6, 2024
@gregsdennis
Copy link
Member

Yes it should, but I couldn't come up with a better design. We are only using the JSON Schema brand color to match with the theme.

Why can't you just use the same design and "A Tour of"?

@benjagm
Copy link
Collaborator

benjagm commented Oct 6, 2024

Like Greg I think we would benefit from adjusting the style / fonts to match the official website.

@JeelRajodiya
Copy link
Member Author

@gregsdennis Do you mean something similar to this?

image

@gregsdennis
Copy link
Member

That fits a lot better with our current design, yes.

@JeelRajodiya
Copy link
Member Author

JeelRajodiya commented Oct 7, 2024

Great!

That fits a lot better with our current design, yes.

I will update the figma design properly and ping @pavanydg when it is ready.
@pavanydg Are you willing to continue working on the issue?

@pavanydg
Copy link
Contributor

pavanydg commented Oct 7, 2024

@JeelRajodiya yes I will continue

@JeelRajodiya
Copy link
Member Author

@pavanydg Please check the figma design I have updated the home page for both dark mode and light mode. you can start working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement New feature or request hacktoberfest This issue is looking for contribution under hacktoberfest event Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants