Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code formatting issue🐛 Bug: #441

Closed
Adity20 opened this issue Mar 4, 2024 · 8 comments
Closed

Code formatting issue🐛 Bug: #441

Adity20 opened this issue Mar 4, 2024 · 8 comments
Assignees
@Adity20
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Blocked There is another issue that needs to be resolved first.

Comments

@Adity20
Copy link
Contributor

Adity20 commented Mar 4, 2024 •
edited
Loading

Describe the bug

Code formatting issue

When accessing the docs page
https://json-schema.org/learn/getting-started-step-by-step

There are few code formatting issues like the issue #371

Steps To Reproduce

https://json-schema.org/learn/getting-started-step-by-step
Screenshot 2024-03-04 232032

Expected Behavior

Formatted code like this
Screenshot 2024-03-04 232744

Screenshots

Device Information [optional]

- OS:
- Browser:
- version:

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No
@Adity20 Adity20 added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Mar 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Welcome to the JSON Schema Community. We are so excited you are here! Thanks a lot for reporting your first issue!! 🎉🎉 Please make sure to take a look to our contributors guide if you plan on opening a pull request. For more details check out README.md file.

@Adity20 Adity20 changed the title 🐛 Bug: Code formatting issue🐛 Bug: Mar 4, 2024
@Adity20
Copy link
Contributor Author

Adity20 commented Mar 4, 2024

@benjagm any views on this?

@benjagm
Copy link
Collaborator

benjagm commented Mar 4, 2024

This is because the extra "..." in the examples I think we already fixed this but seems not. Issue accepted and available.

Thanks for finding it.

@benjagm benjagm added Status: Available No one has claimed responsibility for resolving this issue. and removed Status: Triage This is the initial status for an issue that requires triage. labels Mar 4, 2024
@Adity20
Copy link
Contributor Author

Adity20 commented Mar 4, 2024

Can I work on this one as well as I am half way through the issue #371

@benjagm
Copy link
Collaborator

benjagm commented Mar 5, 2024

Go ahead @Adity20 ! Thanks

@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Mar 5, 2024
@benjagm benjagm moved this to In Progress in Website Contributor Board Mar 5, 2024
@benjagm
Copy link
Collaborator

benjagm commented Mar 5, 2024

Sorry @Adity20 . This is being worked here #349

@benjagm benjagm added Status: Blocked There is another issue that needs to be resolved first. and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Mar 5, 2024
@benjagm
Copy link
Collaborator

benjagm commented Mar 5, 2024

Sorry @Adity20 my fault. Can you please join me to discuss the fix for this in #349?

Let's close this the avoid duplicates.

@benjagm benjagm closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in Website Contributor Board Mar 5, 2024
@Adity20
Copy link
Contributor Author

Adity20 commented Mar 5, 2024

Yeah sure @benjagm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adity20 Adity20

Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Blocked There is another issue that needs to be resolved first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjagm @Adity20