-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enhancement: Auto-assign 'web-team' to PRs #444
Comments
@gregsdennis , I would love to work on this issue. Please assign : ) |
Sure thing. Go for it. (@benjagm please make sure I'm doing this right! 😆) |
@aialok are you finally working on this? I think this can be easily achieved with the field assignees of the issue templates: |
This is for PRs, not issues. The PR template are markdown, not YAML. |
Thank you, @benjagm. I am currently working on this issue. @gregsdennis, I have completed the workflow file, but I have a question. As you mentioned earlier, we need to assign the PR to the web team. However, I couldn't find any API endpoint for directly assigning the PR or any actions in marketplace. Instead, there is an endpoint for requesting a review from the team. I have created a workflow for requesting a review from the team. If this is acceptable, I am ready to submit the PR. You can review an example here: Thank you @gregsdennis @benjagm : ) |
This is what I meant, yes. |
@gregsdennis , Can you please confirm team slug is |
I'm not sure. |
@aialok this is the team: https://github.com/orgs/json-schema-org/teams/web-team |
Thank you ! Making the PR : ) |
@gregsdennis @benjagm I have a suggestion regarding this. Our aim is to get the notification for the review from the desired team. For this, we can use the CODEOWNERS (Github Docs)file which is provided by GitHub specifically for this feature. This file contains the usernames of the maintainers. When someone creates a PR, GitHub automatically We can take this one step further by creating different teams for various areas within the repository. We can also divide maintainers by section, such as assigning different people for Here is an example of the CODEOWNERS file from AsyncAPI's website: |
Thanks @princerajpoot20, this looks cool can be implemented : ) |
I like this solution. Nice find! |
Closed as completed with #505 . Thanks everyone!! |
Is your feature request related to a problem? Please describe
We have a
json-schema.org/web-team
team that should be assigned to PRs. This will enable notifications for everyone in the team when a new PR is opened, and anyone in the team can approve/merge the PR.Describe the solution you'd like
I remember reading that YAML templates can define assignments, but I can't see to find the docs for it.
A custom action would do fine. (Ideally we'd want to extend an existing action, if one is available, rather than creating a new one.)
Describe alternatives you've considered
Manual assignments and tagging are inconsistent.
Additional context
No response
Are you working on this?
No
The text was updated successfully, but these errors were encountered: