fix: correctly set the schema ID when passing it as assoc array #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkarlovi I think this PR could be accepted. If you could just do a rebase and add a changelog entry in Maybe good to know we are seeing multiple issues being reported with associative arrays, which is a concept that doesn't live in JSON. With those two facts we're seeing if we should deprecate the associative array support in the next mayor version |
|
I'm all for deprecating the support as mentioned before. 👍 |
Comment on lines
61
to
67
| if (is_object($schema) && property_exists($schema, 'id')) { | ||
| $schemaURI = $schema->id; | ||
| } elseif (is_array($schema) && array_key_exists('id', $schema)) { | ||
| $schemaURI = $schema['id']; | ||
| } else { | ||
| $schemaURI = SchemaStorage::INTERNAL_PROVIDED_SCHEMA_URI; | ||
| } |
There was a problem hiding this comment.
I believe I've learned something more about the codebase today. These changes should be done respecting the CHECK_MODE_TYPE_CAST. Doing either a loose type check or a strict type check. I believe the following would do so (but requires some testing as well)
Suggested change
| if (is_object($schema) && property_exists($schema, 'id')) { | |
| $schemaURI = $schema->id; | |
| } elseif (is_array($schema) && array_key_exists('id', $schema)) { | |
| $schemaURI = $schema['id']; | |
| } else { | |
| $schemaURI = SchemaStorage::INTERNAL_PROVIDED_SCHEMA_URI; | |
| } | |
| $schemaURI = SchemaStorage::INTERNAL_PROVIDED_SCHEMA_URI; | |
| if ($this->factory->getTypeCheck()::propertyExists($schema, 'id')) { | |
| $schemaURI = $this->factory->getTypeCheck()::propertyGet($schema, 'id'); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #767.