Cleanup Discussion Thread

[thomasdavis]

Hi everybody, just went through and closed 80 issues.

I tried to identify the major concerns with the repo at the moment.

This is just a temporary thread for anyone who is following.

• Document and bump the project to depend on node 10.x
• Documentation needs to be improved (I will personally be tackling this)
• PDF generation has been way too problematic, I think we should remove it from this repo and build another repo and/or write sufficient documentation to guide people how to turn a html export into pdf with ease.
• The CLI tool needs to work effectively from within a theme directory (developing themes should have zero friction)
• Remove all interaction options (I believe it is just init that is still interactive)

Otherwise, there has been great progress this year anyway, hats off to everybody.

(As a personal note, I just use the Gist hosting so I rarely use the CLI but happy to put in some work this holiday season) (We have 1600 people on the Gist hosting now -> https://gist.github.com/search?l=JSON&o=desc&q=resume.json&s=updated)

[rbardini]

Nice work triaging all issues, @thomasdavis!

Local theming was on my to-do list, as I inadvertently broke it when fixing theme package lookup in #367. Let me know if you have any ideas or want some help 🙂

[thomasdavis]

@rbardini Do you know any easy way to support local theme serving in your PR's implementation? I tried reverting the PR but it's too tricky so will just make your PR work with serving local themes.

[thomasdavis]

@rbardini nevermind the above.

I just pushed up 2.1.1 which now allows as others suggested for --theme . or --theme ../some/other/dir

It works for both export and serve

[DustinWehr]

@thomasdavis regarding PDF output: I found an output-to-pdf soluton that worked marvelously for me, after spending way too many hours trying various tools for converting my kendall-themed resume to PDF. I wasn't able to get puppeteer working, for example. These were my requirements:

• Free of unacceptable CSS interpretation bugs, obviously.
• Text searchable. This rules out most screen capture methods.
• No page break issues. There is a screen-capture based tool out there (can't recall the name) that satisfies all my requirements, but charges a monthly premium subscription just to handle pagebreaks intelligently. I used it for a month. If it was a reasonable one-time charge, I'd be recommending it.
• No nasty surprises. Rules out Fireshot. F those guys.

My recommendation is PDF24's online tool (there is a windows desktop version also, but I haven't tried it) https://tools.pdf24.org/en/pdf-converter#xToPdf. If I had standing in the JSON-resume project, I'd reach out to them directly.

Minor extra efforts:

• I had to change two instances of margin-top: -75px; for #photo-header in the kendall theme files, setting it to 0px, else my head gets chopped off. That was the only PDF generation bug I've noticed.
• I had to push the html file to my own web space before I could use their tool. Their file upload tool https://tools.pdf24.org/en/pdf-converter#xToPdf did not work as well, and it wouldn't be able to be pull in my photo in any case.