Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resume serve hot reloading failing with Parse error #682

Open
pgollangi opened this issue Mar 8, 2022 · 1 comment · May be fixed by #722
Open

resume serve hot reloading failing with Parse error #682

pgollangi opened this issue Mar 8, 2022 · 1 comment · May be fixed by #722

Comments

@pgollangi
Copy link

resume serve works file for the file time, but when there are changes in resume.json it is failing with rebuild, error out as following:

Parse error: resume.json
[Browsersync] Reloading Browsers...

OS: Windows 10
resume version: 3.0.6
npm version: 6.14.13
node version: v14.17.0
@benruehl
Copy link

Can confirm.

It seems to work as long as the structure of resume.json is not changed and values are updated only. But as soon as a property is added or removed hot reload breaks and the server needs to be restarted for it to work again.

@karlmayer karlmayer linked a pull request Jun 22, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: yaml support & improve parser error handling experience for 'resume serve' karlmayer/resume-cli
2 participants
@pgollangi @benruehl