Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$tabler_icons is Deprecated #931

Closed
AugustinMauroy opened this issue Feb 4, 2025 · 2 comments · Fixed by #938
Closed

$tabler_icons is Deprecated #931

AugustinMauroy opened this issue Feb 4, 2025 · 2 comments · Fixed by #938
Labels
UI/UX

Comments

@AugustinMauroy
Copy link
Contributor

https://github.com/hashrock/tabler-icons-tsx?tab=readme-ov-file#deprecated

Solution:

  1. https://jsr.io/@preact-icons/tb
  2. Copy pasted used icons in this codebase
@github-project-automation github-project-automation bot moved this to Needs Triage in JSR Feb 4, 2025
@crowlKats crowlKats moved this from Needs Triage to Ready in JSR Feb 4, 2025
@crowlKats crowlKats added the UI/UX label Feb 4, 2025
@lucacasonato
Copy link
Member

I think we can use @preact-icons/tb

@EGAMAGZ
Copy link
Contributor

EGAMAGZ commented Feb 6, 2025

Why not use directly tabler icons for Preact? https://tabler.io/docs/icons/libraries/preact

@EGAMAGZ EGAMAGZ mentioned this issue Feb 7, 2025
Merged
@AugustinMauroy AugustinMauroy mentioned this issue Feb 7, 2025
Closed
github-merge-queue bot pushed a commit that referenced this issue Feb 10, 2025
@EGAMAGZ @AugustinMauroy
refactor(UI): Usage of @preact-icons/tb for icons due to $tabler_icon…
c3f659a 
…s deprecation (#938)

Fixes #931

---------

Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
@github-project-automation github-project-automation bot moved this from Ready to Done in JSR Feb 10, 2025
@EGAMAGZ EGAMAGZ mentioned this issue Feb 19, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 20, 2025
@EGAMAGZ
refactor: replace $tabler_icons with @preact-icons/tb icons (#967)
614417d 
Removes deprecated $tabler_icons import and replaces specific Tabler
icons with equivalent icons from @preact-icons/tb across multiple
components and routes. Part of the icons migration proposed in #931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI/UX
Projects
JSR
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(UI): Usage of @preact-icons/tb for icons due to $tabler_icons deprecation EGAMAGZ/jsr
4 participants
@lucacasonato @crowlKats @EGAMAGZ @AugustinMauroy