adds quote limit #56
adds quote limit #56
Conversation
src/bots/telegram/client.js
Outdated
| @@ -213,6 +215,8 @@ function prepareMessage(msg: Telegram$Message): string { | |||
| if (msg.forward_from) { | |||
| const name: string = Name.from(msg.forward_from); | |||
|
|
|||
| text = prepareQuote(text); | |||
There was a problem hiding this comment.
Forwarded message should be fully displayed, as in the Telegram.
There was a problem hiding this comment.
now i cut it off from here b69eab1
src/bots/telegram/client.js
Outdated
| @@ -222,6 +226,17 @@ function prepareMessage(msg: Telegram$Message): string { | |||
| return text; | |||
| } | |||
|
|
|||
| function prepareQuote(quote) { | |||
There was a problem hiding this comment.
This function needs flow type annotations, I guess.
src/bots/telegram/client.js
Outdated
| } | ||
|
|
||
| const prepared = quote | ||
| .split('\n').slice(0, 3).join('\n').slice(0, quoteLength); |
There was a problem hiding this comment.
this looks like magic, why r u taking first 3 in slice?
There was a problem hiding this comment.
here I leave no more than three lines and no more than the length of the string specified in the config
How can I improve this code?
const firstThreeLines = quote.split('\n').slice(0, 3).join('\n');
const prepared = firstThreeLines.slice(0, quoteLength);
for example like this?
There was a problem hiding this comment.
done look to commit 7c03175
src/bots/telegram/client.js
Outdated
| const prepared = quote | ||
| .split('\n').slice(0, 3).join('\n').slice(0, quoteLength); | ||
| const isMatched = prepared === quote; | ||
| return prepared + (isMatched ? '' : '...'); |
There was a problem hiding this comment.
there is a separate character representing ellipsis … (U+2026) instead of 3 dots
There was a problem hiding this comment.
It seems to me that showing UTF-symbols to people who are in jabber it can be dangerous.
They are not seldom under linux and some of them under terminal
| } | ||
|
|
||
| // get first three lines | ||
| let prepared = quote.split('\n').slice(0, 3).join('\n'); |
There was a problem hiding this comment.
I suggest that we extract that 3 into a config parameter. Probably "quoteLimits": { "characters": 140, "lines": 3 }?
#55