Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Addressing deprecation of PIL.PyAccess in ImageToLPBM #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Swazib0y
Copy link

@Swazib0y Swazib0y commented Nov 8, 2024

#31

Pillow has deprecated PyAccess in favour of C API functionality in V10.x and as such the ImageToLPBM() function no longer works. This proposes changes to that function to remove the dependency.

Copy link
Owner

@jtgans jtgans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to my eye. Lemme run it locally and verify the code works as expected.

"""Simple function to convert a PIL Image into LPBM format."""

i = PIL.PyAccess.new(image, readonly=True)
#Simple function to convert a PIL Image into LPBM format.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave this as a doccomment (the triple-quotes it was before).

g13gui.geany Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jtgans
❌ Swazib0y
You have signed the CLA already but the status is still pending? Let us recheck it.

@jtgans jtgans changed the title fix: Addressing depreceation of PIL.PyAccess in ImageToLPBM fix: Addressing deprecation of PIL.PyAccess in ImageToLPBM Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants