-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when trying to variant call using an R10 model #1059
Comments
It would appear that nanopolish failed to parse the header for some reason. What you pasted looks fine, could you provide the model to me so I can look into this more closely? |
Hi Jared, |
Also, when training for a large human dataset using the r10 branch, the nanopolish train seems to crash after some time:
Any idea how this can be fixed? Now I am trying to extract chromosome 1 and try running only on it. |
The, training for chr1 did not crash, but unfortunately none of the k-mers have been trained.
Could be some parameters? Incase you want to reproduce, all the necessary files are here as a tarball. To reproduce:
This uses the SLOW5 integrated nanopolish r10 branch so we can do the training fast when signal files are residing on NFS and @hiruna72 has separately sent a PR. |
So, going back to the original issue when I run with your model I get this error:
This is because the metadata in nanopolish hasn't been set up for R10.4.1: https://github.com/jts/nanopolish/blob/r10/src/pore_model/nanopolish_model_names.cpp#L17 If I change the model kit to be |
Hi Jared, After renaming as you said, the pore model seems to load. I added some debug prints and the alignment step seem to fail. However, when I run f5c event align with the same model, most reads align and pass calibration (see attached if they look reasonable). Is the adaptive banded event alignment algorithm in the r10 branch different to the one that used to be in Nanopolish main branch (that I used 3 years ago when writing f5c)? I briefly looked at the r10 code and they look considerably different. |
The r10 branch training method re-uses the adaptive banded alignment code, which I made more generic to support this use. I thought it was functionally equivalent but I will look into it. |
I've tried your f5c r10 branch on some local R10.4.1 data I generated but no reads aligned:
Could you provide me with the small set of reads that you used to generate eventalign.tsv and summary.tsv? |
Hi Jared, You can download a little dataset from here. Commandline should like like:
The output is like:
|
@jts Could you also provide me with a little portion of your dataset? Would like to investigate what the difference is? |
Ah, f5c does work for me - I was providing the model incorrectly before. |
I needed to make two changes in 5b6ac67 to make the reads load:
|
Note that the r10 branch is now far out of date with master. Rebasing it seems messy so I will likely re-implement R10.4.1 support from scratch |
Cool. Now it seems to actually do training some k-mers when I tested with chr1. Now let me run with the whole genome. For a PCR'ed dataset, does the following command look right to you? |
Hi @jts After 5 training rounds, roc plots for snps look like this. Do you think the accuracy has saturated and would it be beneficial to go for more rounds? |
Hi Jared,
I have trained a basic k-mer model for R10.4.1 using your R10 branch in nanopolish, using the recent R10.4.1 base models provided by ONT. I am trying to evaluate some variant calls using that, but I am getting the following error
The contents of a.txt looks like:
The head of the ../r10-models/r10.4.1_400bps.nucleotide.9mer.model is like:
I initially had the following but changed the name to R9.4 to see if the name was the issue.
Is there a way to test a new R10 9-mer model in nanopolish?
I manage to do an event alignment using f5c eventalign using this model and most reads successfully aligned. As I am not sure of the best way to check the accuracy of signal alignments, I thought perhaps using the nanopolish variant caller could be a solution. Your thoughts are welcome.
The text was updated successfully, but these errors were encountered: