You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current feature gate is fine as-is, but there are a few advantages to moving the .npz functionality into a separate crate:
The zip dependency could be updated without a breaking change to the ndarray-npy crate. (Updating zip would be a breaking change only for the .npz crate.)
"npy" and "npz" could be removed from the names of some of the traits/functions/types, which would make the names shorter and more similar to naming conventions of other crates. (I'd recommend users to use ndarray_npy as npy; use (the npz crate) as npz;, then e.g. write_zeroed_npy would be npy::write_zeroed and NpzReader would be npz::Reader.)
I think a separate crate is conceptually simpler than a feature.
I'm considering changing the public API as follows:
.npz
functionality into a separate crateReadableElement
toReadElement
WritableElement
toWriteElement
read_npy
tofrom_reader
orread
and change it to takeR: Read
instead of a pathwrite_npy
toto_writer
orwrite
and change it to takeW: Write
instead of a pathwrite_zeroed_npy
toto_writer_zeroed
orwrite_zeroed
The text was updated successfully, but these errors were encountered: