Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify InfiniteScrollListener #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Simplify InfiniteScrollListener #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f170c2a
Simplify the InfiniteScrollListener
Jaimies Dec 2, 2019
2d21bb0
Make visibleThreshold a constant in companion object
Jaimies Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions app/src/main/java/com/droidcba/kedditbysteps/commons/InfiniteScrollListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,14 @@ class InfiniteScrollListener(

private var previousTotal = 0
private var loading = true
private var visibleThreshold = 2
private var firstVisibleItem = 0
private var visibleItemCount = 0
private var totalItemCount = 0

override fun onScrolled(recyclerView: RecyclerView, dx: Int, dy: Int) {
super.onScrolled(recyclerView, dx, dy)

if (dy > 0) {
visibleItemCount = recyclerView.childCount
totalItemCount = layoutManager.itemCount
firstVisibleItem = layoutManager.findFirstVisibleItemPosition()
val visibleItemCount = recyclerView.childCount
val totalItemCount = layoutManager.itemCount
val firstVisibleItem = layoutManager.findFirstVisibleItemPosition()

if (loading) {
if (totalItemCount > previousTotal) {
Expand All @@ -30,7 +26,7 @@ class InfiniteScrollListener(
}
}
if (!loading && (totalItemCount - visibleItemCount)
<= (firstVisibleItem + visibleThreshold)) {
<= (firstVisibleItem + VISIBLE_THRESHOLD)) {
// End has been reached
Log.i("InfiniteScrollListener", "End reached")
func()
Expand All @@ -39,4 +35,7 @@ class InfiniteScrollListener(
}
}

companion object {
const val VISIBLE_THRESHOLD = 2
}
}