Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jump to screen #9

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Tazovsky
Copy link

@Tazovsky Tazovsky commented Apr 2, 2020

PR introduces:

  • jump to screen buttons (named jumpBtn):
    image
  • buttons prevBtn, nextBtn, firstBtn, lastBtn which are wrappers around shiny::actionButton - thanks to that click actions can be easily observed in server
  • run example app from inst/examples/06_jump_controls to see introduced changes
  • when reviewing diffs please turn on following, because something went wrong with line ending conversion in RStudio:
    image

@Tazovsky Tazovsky force-pushed the feature/jump-to-screen branch from 7977627 to c45459f Compare April 2, 2020 21:54
@juba
Copy link
Owner

juba commented Apr 13, 2020

Hi, thanks for your PR and sorry for not answering it sooner.

Unfortunately I have some work to do on shinyglide, in relation with #8, and I think this may interfere with your PR, so I prefer not to merge it for now. But I'll take a look at it as soon as I find time to work on the package.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants