Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Shadow DOM support for Web Components #42

Open
TremayneChrist opened this issue Mar 18, 2019 · 4 comments
Open

Improve Shadow DOM support for Web Components #42

TremayneChrist opened this issue Mar 18, 2019 · 4 comments
Labels
enhancement New feature or request Next v4 Add to version 4 of the library
Milestone
v4

Comments

@TremayneChrist
Copy link
Member

Currently the library only listens to mutations on the main document level. This means that any non-user actioned DOM changes inside a shadow root will not be noticed.

Most of the time this will not be an issue, as user interaction is usually the main cause for resizing to take place. That being said, there are some circumstances where this will cause issues.
@TremayneChrist TremayneChrist added the enhancement New feature or request label Jul 10, 2019
@TremayneChrist
Copy link
Member Author

This could be implemented by collecting a list of observable documents, rather than just listening to events on the main document.

@spb-web
Copy link

spb-web commented Jan 31, 2020

clauderic@2e94a3f

@TremayneChrist TremayneChrist mentioned this issue Mar 2, 2020
Closed
@TremayneChrist TremayneChrist added this to the v4 milestone Mar 4, 2020
@TremayneChrist TremayneChrist added the v4 Add to version 4 of the library label Mar 4, 2020
@TremayneChrist
Copy link
Member Author

This will have to be added to the next milestone (v4), as it will probably need to be part of the refactoring effort.

cc: @goremikin

@TremayneChrist TremayneChrist mentioned this issue Sep 17, 2020
Closed
@TremayneChrist TremayneChrist mentioned this issue Oct 5, 2020
Closed
@TremayneChrist
Copy link
Member Author

Initial support has been added in the v4.0.0-1 release. Feedback welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Next v4 Add to version 4 of the library
Projects
None yet
Milestone
v4
Development

No branches or pull requests
2 participants
@TremayneChrist @spb-web