Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache assets downloaded in build.rs #1209

Open
thewh1teagle opened this issue Nov 18, 2024 · 1 comment · May be fixed by #1214
Open

Cache assets downloaded in build.rs #1209

thewh1teagle opened this issue Nov 18, 2024 · 1 comment · May be fixed by #1214
Labels
enhancement New feature or request prio 2 / future investigation Investigate in future the possibility of implementation

Comments

@thewh1teagle
Copy link

Eg. https://github.com/juhaku/utoipa/blob/master/utoipa-swagger-ui/build.rs#L21
Example how to cache them: https://github.com/thewh1teagle/sherpa-rs/blob/main/sys/build.rs#L459

@juhaku
Copy link
Owner

juhaku commented Nov 21, 2024

I don't remember why and what was the process for the implementation to get the way it is now. But I believe that there was some cache at some point though. There was a check whether the content has already been downloaded and if it was it was not then downloaded again, this has one drawback users need to explicitly call cargo clean first so that they get the latest and greatest version.

Honestly downloading a few bytes of data every now and then does not break Github in my opinion. Another concern is to keep the build and the dependencies as small and minimal as possible. I am open for PR if there is interest in this regard, putting in effort to implement the cache in utoipa-swagger-ui as well. Currently my priorities are elsewhere.

@juhaku juhaku added enhancement New feature or request prio 2 / future investigation Investigate in future the possibility of implementation labels Nov 21, 2024
@thewh1teagle thewh1teagle linked a pull request Nov 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio 2 / future investigation Investigate in future the possibility of implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants