Skip to content

Commit

Permalink
internal/v5: Support multiple values for filters.
Browse files Browse the repository at this point in the history
  • Loading branch information
fabricematrat committed Jul 19, 2018
1 parent 83f2715 commit 6ebf52a
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 3 deletions.
16 changes: 13 additions & 3 deletions internal/charmstore/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -1502,11 +1502,11 @@ func prepareList(sp SearchParams) (filters map[string]interface{}, err error) {
for k, v := range sp.Filters {
switch k {
case "name":
filters[k] = v[0]
filters[k] = orQuery(v)
case "owner":
filters["user"] = v[0]
filters["user"] = orQuery(v)
case "series":
filters["series"] = v[0]
filters["series"] = orQuery(v)
case "type":
if v[0] == "bundle" {
filters["series"] = "bundle"
Expand All @@ -1526,6 +1526,16 @@ func prepareList(sp SearchParams) (filters map[string]interface{}, err error) {
return filters, nil
}

func orQuery(values []string) interface{} {
switch len(values) {
case 0:
return nil
case 1:
return values[0]
}
return bson.D{{"$in", values}}
}

// ListQuery holds a list query from which an iterator
// can be created.
type ListQuery struct {
Expand Down
22 changes: 22 additions & 0 deletions internal/v5/list_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,19 +98,41 @@ func (s *ListSuite) TestSuccessfulList(c *gc.C) {
results: []string{
"cs:trusty/mysql-7",
},
}, {
about: "name filter list",
query: "name=mysql&name=wordpress",
results: []string{
"cs:precise/wordpress-23",
"cs:trusty/mysql-7",
},
}, {
about: "owner filter list",
query: "owner=foo",
results: []string{
"cs:~foo/trusty/varnish-1",
},
}, {
about: "owner filter list",
query: "owner=foo&owner=openstack-charmers",
results: []string{
"cs:trusty/mysql-7",
"cs:~foo/trusty/varnish-1",
},
}, {
about: "series filter list",
query: "series=trusty",
results: []string{
"cs:trusty/mysql-7",
"cs:~foo/trusty/varnish-1",
},
}, {
about: "series filter list",
query: "series=trusty&series=precise",
results: []string{
"cs:precise/wordpress-23",
"cs:trusty/mysql-7",
"cs:~foo/trusty/varnish-1",
},
}, {
about: "type filter list",
query: "type=bundle",
Expand Down

0 comments on commit 6ebf52a

Please sign in to comment.