Remove name from DeleteSercretStructure

juju · Apr 3, 2024 · 2bcabd3 · 2bcabd3
1 parent 78f7a60
commit 2bcabd3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/internal/juju/secrets.go b/internal/juju/secrets.go
@@ -67,7 +67,6 @@ type UpdateSecretInput struct {
 type DeleteSecretInput struct {
 	SecretId  string
 	ModelName string
-	Name      string
 }
 
 func newSecretsClient(sc SharedClient) *secretsClient {
@@ -191,7 +190,7 @@ func (c *secretsClient) DeleteSecret(input *DeleteSecretInput) error {
 		return err
 	}
 	// TODO: think about removing concrete revision.
-	err = secretAPIClient.RemoveSecret(secretURI, input.Name, nil)
+	err = secretAPIClient.RemoveSecret(secretURI, "", nil)
 	if !errors.Is(err, jujuerrors.NotFound) {
 		return typedError(err)
 	}

diff --git a/internal/juju/secrets_test.go b/internal/juju/secrets_test.go
@@ -224,19 +224,17 @@ func (s *SecretSuite) TestDeleteSecret() {
 	ctlr := s.setupMocks(s.T())
 	defer ctlr.Finish()
 
-	secretName := "test-secret"
 	secretId := "secret:9m4e2mr0ui3e8a215n4g"
 
 	secretURI, err := coresecrets.ParseURI(secretId)
 	s.Require().NoError(err)
 
-	s.mockSecretClient.EXPECT().RemoveSecret(secretURI, secretName, nil).Return(nil).AnyTimes()
+	s.mockSecretClient.EXPECT().RemoveSecret(secretURI, "", nil).Return(nil).AnyTimes()
 
 	client := s.getSecretsClient()
 	err = client.DeleteSecret(&DeleteSecretInput{
 		SecretId:  secretId,
 		ModelName: s.testModelName,
-		Name:      secretName,
 	})
 	s.Assert().NoError(err)
 }