Skip to content

Commit

Permalink
chore: updates golangci-lint version
Browse files Browse the repository at this point in the history
  • Loading branch information
alesstimec committed Dec 11, 2024
1 parent 5f21f83 commit 5100d89
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/static-analysis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
version: v1.54.0
version: v1.61.0
args: --print-issued-lines=true

# This runs copyright-check against the codebase
Expand Down
10 changes: 5 additions & 5 deletions internal/provider/resource_application_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func TestAcc_ResourceApplication_Updates(t *testing.T) {
return testingCloud != LXDCloudTesting, nil
},
Config: testAccResourceApplicationUpdates(modelName, 2, true, "machinename"),
Check: resource.TestCheckResourceAttr("juju_application.this", "charm.0.revision", "10"),
Check: resource.TestCheckResourceAttr("juju_application.this", "charm.0.revision", "2"),
},
{
SkipFunc: func() (bool, error) {
Expand Down Expand Up @@ -1037,7 +1037,7 @@ resource "juju_application" "this" {
name = "test-app"
charm {
name = "ubuntu-lite"
revision = 10
revision = 2
}
trust = true
Expand All @@ -1056,7 +1056,7 @@ resource "juju_application" "this" {
name = "test-app"
charm {
name = "ubuntu-lite"
revision = 10
revision = 2
}
trust = true
expose{}
Expand Down Expand Up @@ -1097,7 +1097,7 @@ resource "juju_application" "this" {
name = "test-app"
charm {
name = "ubuntu-lite"
revision = 10
revision = 2
}
trust = true
expose{}
Expand Down Expand Up @@ -1191,7 +1191,7 @@ resource "juju_application" "{{.AppName}}" {
constraints = "{{.Constraints}}"
charm {
name = "ubuntu-lite"
revision = 10
revision = 2
}
endpoint_bindings = {{.EndpointBindings}}
}
Expand Down
4 changes: 2 additions & 2 deletions tools/static-analysis.sh
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ run_linter() {

run_go() {
VER=$(golangci-lint --version | tr -s ' ' | cut -d ' ' -f 4 | cut -d '.' -f 1,2)
if [[ ${VER} != "1.53" ]] && [[ ${VER} != "v1.53" ]]; then
(echo >&2 -e '\nError: golangci-lint version does not match 1.53. Please upgrade/downgrade to the right version.')
if [[ ${VER} != "1.61.0" ]] && [[ ${VER} != "v1.61.0" ]]; then
(echo >&2 -e '\nError: golangci-lint version does not match 1.61.0. Please upgrade/downgrade to the right version.')
exit 1
fi
OUT=$(golangci-lint run -c .github/golangci-lint.config.yaml 2>&1)
Expand Down

0 comments on commit 5100d89

Please sign in to comment.