Skip to content

Commit

Permalink
Merge pull request #1263 from julia-vscode/sp/more-robust-compl-test
Browse files Browse the repository at this point in the history 
chore: make completion test more robust
  • Loading branch information
@pfitzseb
pfitzseb authored Jan 9, 2024
2 parents 199a176 + a1a72d5 commit d327f5a
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions test/requests/test_completions.jl
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@testitem "latex completions" begin
include("../test_shared_server.jl")
include("../test_shared_server.jl")

settestdoc("""
\\therefor
Expand Down Expand Up @@ -48,9 +48,6 @@ end
import .""")
@test_broken completion_test(1, 8).items[1].label == "M"

settestdoc("import Base.")
@test any(item.label == "Meta" for item in completion_test(0, 12).items)

settestdoc("import Base.M")
@test any(item.label == "Meta" for item in completion_test(0, 13).items)

Expand All @@ -62,7 +59,10 @@ end
include("../test_shared_server.jl")

settestdoc("Base.")
@test any(item.label == "Base" for item in completion_test(0, 5).items)
@test length(completion_test(0, 5).items) > 10

settestdoc("Base.B")
@test any(item.label == "Base" for item in completion_test(0, 6).items)

settestdoc("Base.r")
@test any(item.label == "rand" for item in completion_test(0, 6).items)
Expand Down Expand Up @@ -175,7 +175,7 @@ end

@testitem "completion details" begin
include("../test_shared_server.jl")

settestdoc("""
struct Bar end
struct Foo
Expand Down

2 comments on commit d327f5a

@pfitzseb
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/98527

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v4.5.0 -m "<description of version>" d327f5ada36aa7502d3d201b562b6904cc7da13b
git push origin v4.5.0

Please sign in to comment.