Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PR for https://github.com/julianpeeters/sbt-avrohugger/pull/25 #32

Open
julianpeeters opened this issue Sep 22, 2016 · 3 comments
Open

Comments

@julianpeeters
Copy link
Owner

julianpeeters commented Sep 22, 2016

Seeing an unexpected error in the scripted tests after merging conflicting #25 and #30, so I reverted #25 and will try #30 solo first. This means #25 must be resubmitted or otherwise dealt with.

[error] source file '/Users/julianpeeters/Dropbox/avrohugger/avrohugger-core/src/sbt-test/projects/GenericCaseObjectEnumSerializationTests/project' could not be found
@mariussoutier
Copy link
Contributor

Yes I will resubmit #25 after merging manually.

@mariussoutier
Copy link
Contributor

So you added the scripted tests back in? Can you commit them? Then I could merge and fix it all.

@julianpeeters
Copy link
Owner Author

No, haven't had time to add them back in, or think about how ti organize them.

I moved some of the tests, like the OverrideSettings sbt-test project, into avrohugger because I needed to test some of avrohugger's contribution, and felt that keeping them in sbt-avrohugger as well was duplication.

Now I'm of the opinion that a little duplication would be good if it serves to test separate functions, and mostly I was thinking of adding more tests, not moving tests back. So what is left to be done is to decide what tests would be good to have in sbt-avrohugger, regardless of duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants