Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurement formatting issues in RTL #1236

Open
julianpoy opened this issue Jan 7, 2024 · 3 comments
Open

Measurement formatting issues in RTL #1236

julianpoy opened this issue Jan 7, 2024 · 3 comments

Comments

@julianpoy
Copy link
Owner

When the app is displaying a RTL language (such as Hebrew) there are some issues with displayed measurements.

Reported by a user via email, see attached images:

In edit mode, see 3 and a half

image

In Display mode

image

image

In Print mode

image

@levyitay
Copy link
Contributor

levyitay commented Apr 6, 2024

@julianpoy maybe its a good chance to implement better RTL format supporting.
For ex. UI in English and recipe is in Arabic / Hebrew

I'm willing to give a hand here but need some direction for where to start looking

@julianpoy
Copy link
Owner Author

@levyitay So the app UI generally supports RTL pretty well since it's all built on top of Ionic which supports RTL natively. The measurement conversion is custom logic so doesn't generally support RTL, however. It's all located here:

https://github.com/julianpoy/RecipeSage/blob/master/packages/util/shared/src/parsers.ts

I believe there may be a simpler solution, though - perhaps there's a flag for RTL we could apply to the specific element when applied as HTML here: https://github.com/julianpoy/RecipeSage/blob/master/packages/frontend/src/app/pages/recipe-components/recipe/recipe.page.html#L176

levyitay added a commit to levyitay/RecipeSage that referenced this issue May 26, 2024
@levyitay
Copy link
Contributor

@julianpoy I added a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants