-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measurement formatting issues in RTL #1236
Comments
@julianpoy maybe its a good chance to implement better RTL format supporting. I'm willing to give a hand here but need some direction for where to start looking |
@levyitay So the app UI generally supports RTL pretty well since it's all built on top of Ionic which supports RTL natively. The measurement conversion is custom logic so doesn't generally support RTL, however. It's all located here: https://github.com/julianpoy/RecipeSage/blob/master/packages/util/shared/src/parsers.ts I believe there may be a simpler solution, though - perhaps there's a flag for RTL we could apply to the specific element when applied as HTML here: https://github.com/julianpoy/RecipeSage/blob/master/packages/frontend/src/app/pages/recipe-components/recipe/recipe.page.html#L176 |
@julianpoy I added a PR |
When the app is displaying a RTL language (such as Hebrew) there are some issues with displayed measurements.
Reported by a user via email, see attached images:
In edit mode, see 3 and a half
In Display mode
In Print mode
The text was updated successfully, but these errors were encountered: