Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require-ascii: Allow extended ASCII characters #63

Closed
kenorb opened this issue Jul 13, 2020 · 3 comments · Fixed by #64
Closed

require-ascii: Allow extended ASCII characters #63

kenorb opened this issue Jul 13, 2020 · 3 comments · Fixed by #64

Comments

@kenorb
Copy link

kenorb commented Jul 13, 2020 •
edited
Loading 

Check file encoding.........................................................Failed
- hook id: require-ascii
- exit code: 1

README.md: line 270 column 11 character "©" (decimal 169)

I'd like to exclude the copyright character from README ("©"), is that possible, without disabling the whole hook?
@kenorb
Copy link
Author

kenorb commented Jul 13, 2020

Also, isn't © part of ASCII, but extended?

See: https://theasciicode.com.ar/extended-ascii-code/copyright-symbol-ascii-code-184.html

@kenorb kenorb changed the title require-ascii: exclude certain characters? require-ascii: Allow extended ASCII characters Jul 13, 2020
jumanjiman added a commit to jumanjiman/pre-commit-hooks-1 that referenced this issue Jul 13, 2020
@jumanjiman
recognize and allow all 8 bits of ascii characters
9e95bff 
Resolves jumanjihouse#63
(allow copyright character)
@jumanjiman jumanjiman mentioned this issue Jul 13, 2020
Merged
jumanjiman added a commit to jumanjiman/pre-commit-hooks-1 that referenced this issue Jul 13, 2020
@jumanjiman
recognize and allow all 8 bits of ascii characters
82acbc5 
Resolves jumanjihouse#63
(allow copyright character)
@jumanjiman
Copy link
Member

Also, isn't © part of ASCII, but extended?

great point!

I've opened #62 to allow the whole set of extended ascii characters.

@jumanjiman
Copy link
Member

@kenorb

Rev 2.1.4 allows the whole extended ascii set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

recognize and allow all 8 bits of ascii characters jumanjiman/pre-commit-hooks-1
2 participants
@kenorb @jumanjiman