Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutability check for array multiplication #272

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Conversation

odow
Copy link
Member

@odow odow commented Mar 24, 2024

Closes #271

@odow odow force-pushed the od/fix-mutability-size branch from 101ebc2 to 046aba9 Compare March 24, 2024 22:04
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (a9779ff) to head (f00bd50).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   91.95%   91.92%   -0.04%     
==========================================
  Files          23       23              
  Lines        2200     2216      +16     
==========================================
+ Hits         2023     2037      +14     
- Misses        177      179       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/interface.jl Outdated Show resolved Hide resolved
Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, it's the first case where a custom mutability is needed

@odow odow merged commit 69b1c51 into master Mar 26, 2024
10 of 11 checks passed
@odow odow deleted the od/fix-mutability-size branch March 26, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bug in operate!!(*, A, B)
2 participants