-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update profile page, leaderboard and quest-cards #1474
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test resultsDetails 19 tests across 3 suites Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission |
Test results (3/4)Details 5 tests across 2 suites Flaky testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to X |
Test results (1/4)Details 6 tests across 2 suites Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission |
Test results (4/4)Details 5 tests across 2 suites |
Test results (2/4)Details 5 tests across 1 suite Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color |
import { LeaderboardPage as LeaderboardPageComponent } from '@/components/Leaderboard/LeaderboardPage'; | ||
|
||
const LeaderboardPage = ({ page }: { page?: string }) => { | ||
const parsedPage = page ? parseInt(page, 10) : NaN; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parseInt(page, 10) will have the same result without the if statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried something not better, let me know what you think?
src/utils/effigyAddressFormatter.ts
Outdated
export const effigyAddressFormatter = (address?: string) => { | ||
const addressChunks = address?.split('...'); | ||
if (addressChunks?.length === 2) { | ||
const addressPreChunksLength = addressChunks[0].length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tcheee what do you mean?
Ticket: https://lifi.atlassian.net/browse/LF-10647