Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update profile page, leaderboard and quest-cards #1474

Open
wants to merge 51 commits into
base: develop
Choose a base branch
from

Conversation

dennyscode
Copy link
Contributor

@dennyscode dennyscode added the WIP Work in Progress label Oct 31, 2024
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jumper-exchange ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 8:30pm

Copy link

github-actions bot commented Oct 31, 2024

Playwright test results

passed  16 passed
skipped  3 skipped

Details

stats  19 tests across 3 suites
duration  3 minutes, 29 seconds
commit  7ac022d

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to Supefest
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color

@dennyscode dennyscode removed the WIP Work in Progress label Nov 6, 2024
Copy link

github-actions bot commented Dec 5, 2024

Test results (3/4)

passed  4 passed
flaky  1 flaky

Details

stats  5 tests across 2 suites
duration  2 minutes, 23 seconds
commit  863f859

Flaky tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to X

Copy link

github-actions bot commented Dec 5, 2024

Test results (1/4)

passed  5 passed
skipped  1 skipped

Details

stats  6 tests across 2 suites
duration  1 minute, 5 seconds
commit  863f859

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission

Copy link

github-actions bot commented Dec 5, 2024

Test results (4/4)

passed  5 passed

Details

stats  5 tests across 2 suites
duration  1 minute, 13 seconds
commit  863f859

Copy link

github-actions bot commented Dec 5, 2024

Test results (2/4)

passed  4 passed
skipped  1 skipped

Details

stats  5 tests across 1 suite
duration  33.6 seconds
commit  863f859

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color

.env.development Outdated Show resolved Hide resolved
import { LeaderboardPage as LeaderboardPageComponent } from '@/components/Leaderboard/LeaderboardPage';

const LeaderboardPage = ({ page }: { page?: string }) => {
const parsedPage = page ? parseInt(page, 10) : NaN;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parseInt(page, 10) will have the same result without the if statement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried something not better, let me know what you think?

src/components/Leaderboard/Leaderboard.tsx Outdated Show resolved Hide resolved
src/components/illustrations/XPIcon.tsx Show resolved Hide resolved
src/const/zeroAddress.ts Outdated Show resolved Hide resolved
export const effigyAddressFormatter = (address?: string) => {
const addressChunks = address?.split('...');
if (addressChunks?.length === 2) {
const addressPreChunksLength = addressChunks[0].length;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcheee what do you mean?

src/utils/formatNumbers.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants