-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Zapping; #1550
base: develop
Are you sure you want to change the base?
feat: Zapping; #1550
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test resultsDetails 19 tests across 3 suites Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission |
src/hooks/useIonicData.ts
Outdated
const data = await res.json(); | ||
|
||
return { | ||
data, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can only return data, react-query will take care of isSccess and isLoading itself
src/hooks/useZaps.ts
Outdated
|
||
const { data } = resFormatted; | ||
|
||
return { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Test results (3/4)Details 5 tests across 2 suites |
Test results (4/4)Details 5 tests across 2 suites |
Test results (1/4)Details 6 tests across 1 suite Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission |
Test results (2/4)Details 5 tests across 1 suite Flaky testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to LI.FI Scan Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to Supefest |
…o-use-the-zap-widget
…ponents-to-use-the-zap-widget' into LF-11022
createConfig({ | ||
apiKey: process.env.NEXT_PUBLIC_LIFI_API_KEY, | ||
apiUrl: process.env.NEXT_PUBLIC_ZAP_API_URL, | ||
providers: [EVM(), Solana(), UTXO()], | ||
integrator: process.env.NEXT_PUBLIC_WIDGET_INTEGRATOR, | ||
rpcUrls: { | ||
...JSON.parse(process.env.NEXT_PUBLIC_CUSTOM_RPCS), | ||
...publicRPCList, | ||
}, | ||
preloadChains: true, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should set this only on mount?
|
||
export default async function MainLayout({ children }: PropsWithChildren) { | ||
return ( | ||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary fragments
import type { Metadata } from 'next'; | ||
import type { PropsWithChildren } from 'react'; | ||
import { Layout } from 'src/Layout'; | ||
import { WalletProviderZap } from 'src/providers/WalletProvider/ZapWalletProvider'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the component and file could be more consistent 😅
No description provided.