Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Zapping; #1550

Open
wants to merge 35 commits into
base: develop
Choose a base branch
from
Open

feat: Zapping; #1550

wants to merge 35 commits into from

Conversation

admsk2
Copy link
Contributor

@admsk2 admsk2 commented Nov 27, 2024

No description provided.

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jumper-exchange ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 5:43pm

Copy link

github-actions bot commented Nov 27, 2024

Playwright test results

passed  16 passed
skipped  3 skipped

Details

stats  19 tests across 3 suites
duration  3 minutes, 15 seconds
commit  9eb2e90

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to Supefest
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color

@admsk2 admsk2 added the WIP Work in Progress label Nov 27, 2024
const data = await res.json();

return {
data,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can only return data, react-query will take care of isSccess and isLoading itself


const { data } = resFormatted;

return {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link

github-actions bot commented Dec 5, 2024

Test results (3/4)

passed  5 passed

Details

stats  5 tests across 2 suites
duration  56.8 seconds
commit  31f9e3a

Copy link

github-actions bot commented Dec 5, 2024

Test results (4/4)

passed  5 passed

Details

stats  5 tests across 2 suites
duration  57.9 seconds
commit  31f9e3a

Copy link

github-actions bot commented Dec 5, 2024

Test results (1/4)

passed  5 passed
skipped  1 skipped

Details

stats  6 tests across 1 suite
duration  1 minute, 27 seconds
commit  31f9e3a

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission

Copy link

github-actions bot commented Dec 5, 2024

Test results (2/4)

passed  2 passed
flaky  1 flaky
skipped  2 skipped

Details

stats  5 tests across 1 suite
duration  1 minute, 5 seconds
commit  31f9e3a

Flaky tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to LI.FI Scan

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to Supefest
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color

@admsk2 admsk2 removed the WIP Work in Progress label Dec 9, 2024
…ponents-to-use-the-zap-widget' into LF-11022
Comment on lines +29 to +39
createConfig({
apiKey: process.env.NEXT_PUBLIC_LIFI_API_KEY,
apiUrl: process.env.NEXT_PUBLIC_ZAP_API_URL,
providers: [EVM(), Solana(), UTXO()],
integrator: process.env.NEXT_PUBLIC_WIDGET_INTEGRATOR,
rpcUrls: {
...JSON.parse(process.env.NEXT_PUBLIC_CUSTOM_RPCS),
...publicRPCList,
},
preloadChains: true,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should set this only on mount?


export default async function MainLayout({ children }: PropsWithChildren) {
return (
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary fragments

import type { Metadata } from 'next';
import type { PropsWithChildren } from 'react';
import { Layout } from 'src/Layout';
import { WalletProviderZap } from 'src/providers/WalletProvider/ZapWalletProvider';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the component and file could be more consistent 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants