feat: integrate dynamic images on SEO pages #1557
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test results
Details
Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission |
|
|
|
|
Test results (4/4)
Details
|
Test results (3/4)
Details
|
Test results (2/4)
Details
Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color |
Test results (1/4)
Details
Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission |
src/app/ui/bridge/StepsExplainer.tsx
Outdated
| you have the correct ${sourceChain?.name} wallet address and that your | ||
| ${sourceToken?.name} account is funded.`} | ||
| img={{ | ||
| imgUrl: `/api/widget-selection?fromToken=${sourceToken.address}&fromChainId=${sourceChain.id}&toToken=${destinationToken.address}&toChainId=${destinationChain.id}&amount=${WIDGET_AMOUNT}&theme=${theme.palette.mode}&isSwap=false`, |
There was a problem hiding this comment.
Thing I did not see before, those imgUrl params are all duplicated, you can use querystring to make it clearer (and avoid duplication by declaring those at the top of the file)
There was a problem hiding this comment.
I have extracted this to first create an object[] called "steps" which takes in the necessary information for each step-item explanation. In the render message it loops through that. This seperates the data-logic from the returned render-logic. In addition with our new function "getWidgetImageProps" it should be much cleaner now.
Wdyt?
Ticket: https://lifi.atlassian.net/browse/LF-10781