chore: adjust bg color on scan page #1578
Open
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Test results (2/4)
Details
Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color |
Test results (4/4)
Details
|
Test results (1/4)
Details
Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission |
Test results (3/4)
Details
|
dennyscode
changed the title
dennyscode
changed the title
bojank93
approved these changes
Dec 10, 2024
Issue on the menu if the user is coming from a dark theme
|
tcheee
requested changes
Dec 12, 2024
| @@ -70,7 +69,7 @@ export const useMainMenuContent = () => { | |||
|
|
|||
| let mainMenu: any[] = []; | |||
|
|
|||
| if (configTheme?.hasThemeModeSwitch) { | |||
| if (configTheme?.hasThemeModeSwitch && !disableThemeSwitch) { | |||
There was a problem hiding this comment.
won't be enough as the dark theme does not exist so we have to force the light theme on this page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://lifi.atlassian.net/browse/LF-11330