Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show event end time on schedule #7

Closed
wants to merge 3 commits into from

Conversation

Calvin-LL
Copy link

@Calvin-LL Calvin-LL commented Aug 19, 2023

At DEF CON this year I found it inconvenient to have to click into an event to see when it ends. I wanted to prioritize events like talks that lasts around an hour, over events like CTFs that last all day which I can go check out later. This PR adds the end times of the events in schedule.

I have also made PRs for this feature for the web and iOS version: PR for web, PR for iOS.

It looks like this when I run it in the emulator:

light dark
Screenshot_20230819_204418 Screenshot_20230819_204428

@Advice-Dog
Copy link
Contributor

We do want to show the duration of the events better, but this change would clutter the UI and be overwhelming to read.

@Calvin-LL
Copy link
Author

Calvin-LL commented Aug 20, 2023

We do want to show the duration of the events better, but this change would clutter the UI and be overwhelming to read.

Perhaps we can have the end time in a smaller font and lighter color? I think the AM PM indicators can also be removed if we want less clutter, the iOS version seems to do fine with them.

@Calvin-LL
Copy link
Author

We do want to show the duration of the events better, but this change would clutter the UI and be overwhelming to read.

Perhaps we can have the end time in a smaller font and lighter color? I think the AM PM indicators can also be removed if we want less clutter, the iOS version seems to do fine with them.

I have updated the PR and screenshot to remove AM/PM, remove the "-" and make the end time text smaller.

@Advice-Dog
Copy link
Contributor

We do want to show the duration of the events better, but this change would clutter the UI and be overwhelming to read.

Perhaps we can have the end time in a smaller font and lighter color? I think the AM PM indicators can also be removed if we want less clutter, the iOS version seems to do fine with them.

I have updated the PR and screenshot to remove AM/PM, remove the "-" and make the end time text smaller.

I don't think this is the best solution for this problem, you have to consider events that span multiple days and how it effects readability. I'm considering adding the duration into the tags, that would allow the user to filter by duration, as well as see duration at a glance.

And the future plans will be to move to a sticky header for the time slot, so only the first event of a time block will have a start time.

@Advice-Dog Advice-Dog deleted the branch junctor:feature/2023 March 15, 2024 00:04
@Advice-Dog Advice-Dog closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants