Refactoring suggestions

[baurmatt]

• Remove inheritance from all classes besides init.pp (https://puppet.com/docs/puppet/4.10/lang_classes.html#inheritance)
• Drop support for Puppet 3 (At least in the master branch)
• Verify that either config_file_source or config_file_template is set and use only 1 file resource in config.pp
• Remove notices/warnings in init/service.pp

[juniorsysadmin]

Hi @baurmatt , thank you for your suggestions. This module hasn't been maintained for some time and I personally don't use it on production systems. However, I'm okay with merging contributions.
In addition to what you mentioned, to keep up with good practices it would be preferable to also:

• Drop EOL operating systems (and therefore perhaps support for non-systemd inits)
• Use data in modules
• Use data types
• Use non-legacy facts
• Use camptocamp/systemd

[baurmatt]

Hey @juniorsysadmin, sorry i should have added a couple more lines as explanation. I've reviewed this module because i wanted to replace some old legacy code of ours with it. After realizing that it would need some refactoring to pass our internal processes, I've decided to just cleanup our internal code. Especially because we're thinking about removing the service with the next OS upgrade and I didn't want to put too much effort in it.

Still I wanted to leave my findings for a possible refactoring of this module in the future.