Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation (at least for TF) and weight_decouple is not an option #51

Open
grofte opened this issue Jun 7, 2021 · 2 comments
Open

Comments

@grofte
Copy link

grofte commented Jun 7, 2021

Hiya,

In the ReadME you say that Rectify is implemented as an option but the default is True. I would update the ReadME to reflect that.

You also make it sound like weight_decouple is an available option in the TF version. But it isn't:

| AdaBeliefOptimizer(learning_rate=0.001, beta_1=0.9, beta_2=0.999, epsilon=1e-14, weight_decay=0.0, rectify=True, amsgrad=False, sma_threshold=5.0, total_steps=0, warmup_proportion=0.1, min_lr=0.0, name='AdaBeliefOptimizer', print_change_log=True, **kwargs)

I just get an error message when I try to set weight_decouple=True.

Great work otherwise!

@juntang-zhuang
Copy link
Owner

Thanks for the feedback!
I'll update readme file to clarify the configurations for tf version.

@grofte
Copy link
Author

grofte commented Jun 13, 2021

It's also in the log for version 2.0:

�[31mPlease check your arguments if you have upgraded adabelief-tf from version 0.0.1.
�[31mModifications to default arguments:
�[31m                           eps  weight_decouple    rectify
-----------------------  -----  -----------------  -------------
adabelief-tf=0.0.1       1e-08  Not supported      Not supported
>=0.1.0 (Current 0.2.0)  1e-14  supported          default: True
�[34mSGD better than Adam (e.g. CNN for Image Classification)    Adam better than SGD (e.g. Transformer, GAN)
----------------------------------------------------------  ----------------------------------------------
Recommended epsilon = 1e-7                                  Recommended epsilon = 1e-14
�[34mFor a complete table of recommended hyperparameters, see
�[34mhttps://github.com/juntang-zhuang/Adabelief-Optimizer
�[32mYou can disable the log message by setting "print_change_log = False", though it is recommended to keep as a reminder.
�[0m

But was I supposed to use version 2.1? The readme said 2.0 was the current version so that's what I went with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants