Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support writing date/time values #36

Merged
merged 7 commits into from
Apr 1, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Drop the redundant methods
  • Loading branch information
junyuan-chen committed Apr 1, 2024
commit 9106e5402f6372e1c29d91c1227a2ab22bdf1730
3 changes: 0 additions & 3 deletions src/writestat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ rstype(::Type{Float32}) = READSTAT_TYPE_FLOAT
rstype(::Type{<:Real}) = READSTAT_TYPE_DOUBLE
rstype(::Type{<:AbstractString}) = READSTAT_TYPE_STRING
rstype(type) = error("element type $type is not supported")
# Work around for the different eltype of MappedArray on older Julia versions
rstype(::Type{Union{T, Date}}) where T<:Real = rstype(T)
rstype(::Type{Union{T, DateTime}}) where T<:Real = rstype(T)

# Stata .dta format before version 118 does not support Unicode for string variables
const default_file_format_version = Dict{String, Int}(
Expand Down
Loading