Fix/transfer hook comment #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsource147
approved these changes
Oct 14, 2024
andrewsource147
pushed a commit
that referenced
this pull request
Oct 24, 2024
urieltan
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Add `cancel_vesting_escrow` instruction (#15) * Add `cancel_vesting_escrow` instruction * Fix feedbacks * Fix feedbacks * Fix feedback + refactor code * Update error msg & declaration * Minor * Support token_2022 program (#5) * Support token-2022 program * Add `cancel_vesting_escrow_v2` to support token_2022 * refactor * Update fixes for feedbacks * Remove Unauthorized * remove unused errors * add staging CI * fix typo * Fix feedbacks * Revert constraint checking for sender_token * Add support for ConfidentialTransferMint / PermanentDelegate / TransferHook / MintCloseAuthority & update feedbacks * Fix feedbacks * Update Feedbacks * Fix feedback * Add change log + increase compute unit for cancel instruction (#17) * Add change log + increase compute unit for cancel instruction * Update detailed changes * fix comments * Increase anchor to 0.30.1 & Add support for group/member token extensions (#18) * Increase anchor to 0.30.1 * Implement support for GroupPointer & GroupMemberPointer * Minor * Remove support for Group & GroupMember * Add changelog * Update changelog * change transfer hook error text (#20) * harvest fees when closing token2022 token account (#19) * harvest fees when closing token2022 token account * remove signer for harvesting fees * fix harvesting fees * add test for harvest fee during cancelation * fix test to include transfer_fee calculation * nit: fix comments and function name * update packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.