Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace local secure_write method with jupyter core's #381

Closed
kevin-bates opened this issue Jan 12, 2021 · 2 comments · Fixed by #382
Closed

Replace local secure_write method with jupyter core's #381

kevin-bates opened this issue Jan 12, 2021 · 2 comments · Fixed by #382

Comments

@kevin-bates
Copy link
Member

When the secure_write machinations were taking place, we added an implementation to jupyter_server before it found its final resting place in jupyter_core. The second half of this notebook issue comment exposed that its replacement was never followed up. We'll track its replacement via this issue.

@Zsailer
Copy link
Member

Zsailer commented Jan 12, 2021

Ah, yes. This was started in #357, but closed later.

@kevin-bates
Copy link
Member Author

Ok. Thanks for the pointer. This lead to using core's versions of is_hidden, is_file_hidden, and exists as well. PR on its way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants